Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Gracefully handle incorrect assets in GET /offers #2634

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

2opremio
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fixes #2466

Gracefully handle incorrect assets in the query parameters of GET /offers.

Before this change, a panic happened and a 500 HTTP error was returned.

Why

A 500 is incorrect and not helpful for the end user.

Known limitations

N/A

@cla-bot cla-bot bot added the cla: yes label May 29, 2020
Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a regression test with query params that would caught this error? Also we should have caught that it was invalid in the custom validators for each part of the asset, that is assetType or asset

services/horizon/internal/actions/offer.go Outdated Show resolved Hide resolved
services/horizon/internal/actions/offer.go Outdated Show resolved Hide resolved
@2opremio 2opremio force-pushed the 2466-handle-incorrect-offer-assets branch from 7ab0037 to 262c1ff Compare June 1, 2020 23:55
@2opremio
Copy link
Contributor Author

2opremio commented Jun 1, 2020

@abuiles PTAL

@2opremio
Copy link
Contributor Author

2opremio commented Jun 1, 2020

Also we should have caught that it was invalid in the custom validators for each part of the asset, that is assetType or asset

I would rather address this separately. But I will do it here if you think I should.

@2opremio 2opremio force-pushed the 2466-handle-incorrect-offer-assets branch from 262c1ff to f91a088 Compare June 4, 2020 23:15
@2opremio 2opremio merged commit 5a773bb into master Jun 4, 2020
@2opremio 2opremio deleted the 2466-handle-incorrect-offer-assets branch June 4, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services/horizon: Handle bad request to offers, don't throw a 500
2 participants