all: Revert SEP23 (Muxed Account strkeys) #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change completely removes support for M-strkeys. After this change: 1. There is no way for users of the Go SDK to create or parse M-strkeys. In particular they cannot provide M-strkeys to create a transaction and in order to get the strkey of `MuxedAccount` they first need to transform it to an `AccountId` leading to a G-strkey (i.e. the memo id being is dropped). 2. Users **can** still tinker with `MuxedAccounts` using the XDR representation, of transactions (using the using the generated code in the `xdr` package).
2opremio
requested review from
abuiles,
bartekn,
tomerweller,
tamirms and
MonsieurNicolas
tamirms
reviewed
May 21, 2020
tamirms
approved these changes
May 21, 2020
|
LGTM. Thanks for the quick turnaround |
MonsieurNicolas
approved these changes
May 21, 2020
This was referenced May 22, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This change completely removes support for M-strkeys (SEP23), introduced in #2491
After this change:
There is no way for users of the Go SDK to create or parse M-strkeys. In
particular they cannot provide M-strkeys to create a transaction and in order
to get the strkey of
MuxedAccountthey first need to transform it to anAccountIdleading to a G-strkey (i.e. the memo id being is dropped).Users can still tinker with
MuxedAccountsin the XDR representationof transactions (using the generated code in the
xdrpackage).Why
We don't want to encourage users to store M-strkeys, since SEP 23 is still a draft.
Known limitations
We still need to do the same for all the other SDKs
NOTE: To make sure there are no further communication confusions regarding this, I won't be merging this until I get an explicit approval from @MonsieurNicolas and @tomerweller