services/horizon/internal/txsub: Implement Horizon DB sequence provider #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
force-pushed
the
sequence-provider
branch
from
e6dcf20
to
a790c5e
Compare
bartekn
approved these changes
May 19, 2020
| @@ -226,6 +225,6 @@ func initSubmissionSystem(app *App) { | |||
| History: &history.Q{Session: app.HorizonSession(context.Background())}, | |||
| SkipCoreChecks: app.config.IngestFailedTransactions, | |||
| }, | |||
| Sequences: cq.SequenceProvider(), | |||
| Sequences: &history.Q{Session: app.HorizonSession(context.Background())}, | |||
There was a problem hiding this comment.
I wonder if we should have a separate connection pool for txsub too. Let'd discuss in a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #2577
SequenceProviderbacked by horizon's DB instead of the stellar core dbSequenceProviderinstead of the stellar core backed providerSequenceProviderimplementationWhy
We want to minimize the dependency between Horizon and Stellar Core internals. By using a horizon backed
SequenceProviderwe avoid querying Stellar Core's account table.Known limitations
[N/A]