Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/horizon: Marshall int64 MaxFee and FeeCharged fields as JSON strings #2555

Merged
merged 1 commit into from
May 6, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented May 5, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Marshall int64 MaxFee and FeeCharged fields as JSON strings

Why

Javascript does not support 64 bit integers so to represent 64 bit values we need to represent them as strings.

Known limitations

[N/A]

@cla-bot cla-bot bot added the cla: yes label May 5, 2020
Javascript does not support 64 bit integers so to represent 64 bit values we need to represent them as strings.
@tamirms tamirms changed the base branch from master to release-horizon-v1.3.0 May 5, 2020 18:23
@tamirms tamirms added this to the Horizon 1.3.0 milestone May 5, 2020
@tamirms tamirms requested a review from a team May 5, 2020 18:24
@tamirms tamirms merged commit c2d7c4d into stellar:release-horizon-v1.3.0 May 6, 2020
@tamirms tamirms deleted the int64-json branch May 6, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants