Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon/internal/db2/schema: Drop participant id columns #2532

Merged
merged 2 commits into from
May 1, 2020
Merged

services/horizon/internal/db2/schema: Drop participant id columns #2532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f95bb
Drop participant id columns
tamirms May 1, 2020
90c2af2
Update CHANGELOG
tamirms May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions services/horizon/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
All notable changes to this project will be documented in this
file. This project adheres to [Semantic Versioning](http://semver.org/).

## v1.2.1

* Remove `id` columns from `history_operation_participants` and `history_transaction_participants` to prevent possible integer overflow [#2532](https://github.com/stellar/go/pull/2532).

## v1.2.0

### Scheduled Breaking Changes
Expand Down
23 changes: 23 additions & 0 deletions services/horizon/internal/db2/schema/bindata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions services/horizon/internal/db2/schema/migrations/35_drop_participant_id.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
-- +migrate Up

ALTER TABLE history_operation_participants
DROP COLUMN id;

ALTER TABLE history_transaction_participants
DROP COLUMN id;

-- +migrate Down

ALTER TABLE history_operation_participants
ADD COLUMN id integer;

ALTER TABLE history_transaction_participants
ADD COLUMN id integer;