Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: Validate transaction hash IDs as 64 lowecase hex chars #2394

Merged
merged 9 commits into from
Mar 18, 2020
Merged

services/horizon: Validate transaction hash IDs as 64 lowecase hex chars #2394

merged 9 commits into from
Mar 18, 2020

Commits on Mar 17, 2020

  1. Validate transaction hash IDs as 64 lowecase hex chars 

    Also, sneak in some minor improvements in `handler.go`
    @2opremio
    2opremio committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    b7c4058 View commit details
    Browse the repository at this point in the history

  2. Clarify that transaction hashes are lowercase

    @2opremio
    2opremio committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    e5ccf7f View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG

    @2opremio
    2opremio committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    71d2b47 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Extend hash validation to all operations

    @2opremio
    2opremio committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    345b5ca View commit details
    Browse the repository at this point in the history

  2. Extend transaction tests

    @2opremio
    2opremio committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    fc9d999 View commit details
    Browse the repository at this point in the history

  3. Accept empty hashes 

    This is needed since actions try to decode all parameters even if not present
    @2opremio
    2opremio committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    6c8cf28 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @2opremio
    2opremio committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    ddf5898 View commit details
    Browse the repository at this point in the history

  5. Get rid of (*Base)GetTransactionID()

    @2opremio
    2opremio committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    f7b0c50 View commit details
    Browse the repository at this point in the history

  6. Extend tx hash test to all endpoints

    @2opremio
    2opremio committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    cd6eff2 View commit details
    Browse the repository at this point in the history