Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/ticker: update *.json files atomically #2362

Merged
merged 1 commit into from
Mar 6, 2020
Merged

services/ticker: update *.json files atomically #2362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions services/ticker/internal/utils/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ func PanicIfError(e error) {
}
}

// WriteJSONToFile wrtites a json []byte dump to <filename>
// WriteJSONToFile atomically writes a json []byte dump to <filename>
// It ensures atomicity by first creating a tmp file (filename.tmp), writing
// the contents to it, then renaming it to the originally specified filename.
func WriteJSONToFile(jsonBytes []byte, filename string) (numBytes int, err error) {
f, err := os.Create(filename)
tmp := fmt.Sprintf("%s.tmp", filename)
f, err := os.Create(tmp)
PanicIfError(err)
defer f.Close()

Expand All @@ -32,6 +35,7 @@ func WriteJSONToFile(jsonBytes []byte, filename string) (numBytes int, err error
return
}

err = os.Rename(tmp, filename)
return
}

Expand Down