Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update changelogs with drop of Go 1.12 support #2346

Merged
merged 1 commit into from
Feb 29, 2020
Merged

doc: update changelogs with drop of Go 1.12 support #2346

merged 1 commit into from
Feb 29, 2020

Conversation

leighmcculloch
Copy link
Member

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update all CHANGELOG.md's mentioning that Go 1.12 support has been
dropped.

Why

I dropped Go 1.12 support in #2325 but I overlooked adding a note to the
changelogs.

Known limitations

N/A

### What
Update all CHANGELOG.md's mentioning that Go 1.12 support has been
dropped.

### Why
I dropped Go 1.12 support in #2325 but I overlooked adding a note to the
changelogs.
@leighmcculloch leighmcculloch self-assigned this Feb 28, 2020
@cla-bot cla-bot bot added the cla: yes label Feb 28, 2020
@leighmcculloch leighmcculloch merged commit df08fd7 into stellar:master Feb 29, 2020
@leighmcculloch leighmcculloch deleted the go114changelogs branch February 29, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants