Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: use Go 1.14 for building in docker images #2345

Merged
merged 3 commits into from
Mar 3, 2020
Merged

all: use Go 1.14 for building in docker images #2345

merged 3 commits into from
Mar 3, 2020

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Feb 28, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Use Go 1.14 for building in docker images.

Why

We recently switched to building with Go 1.13 and 1.14 in #2325 and we should use the latest version for our builds.

Known limitations

N/A

### What
Use Go 1.14 for building in docker images.

### Why
We recently switched to building with Go 1.13 and 1.14 and we should use
the latest version for our builds.
Copy link
Contributor

@brahman81 brahman81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leighmcculloch leighmcculloch merged commit ef8417b into stellar:master Mar 3, 2020
@leighmcculloch leighmcculloch deleted the go114dockerimages branch March 3, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants