Fix horizon db reap command

[tamirms]

PR Checklist

PR Structure

• This PR has reasonably narrow scope (if not, break it down into smaller PRs).
• This PR avoids mixing refactoring changes with feature changes (split into two PRs
  otherwise).
• This PR's title starts with name of package that is most changed in the PR, ex.
  services/friendbot, or all or doc if the changes are broad or impact many
  packages.

Thoroughness

• This PR adds tests for the most critical parts of the new functionality or fixes.
• I've updated any docs (developer docs, .md
  files, etc... affected by this change). Take a look in the docs folder for a given service,
  like this one.

Release planning

• I've updated the relevant CHANGELOG (here for Horizon) if
  needed with deprecations, added features, breaking changes, and DB schema changes.
• I've decided if this PR requires a new major/minor version according to
  semver, or if it's mainly a patch change. The PR is targeted at the next
  release branch if it's not a patch change.

What

Close #2307

When the db reap command is called, ledger.CurrentState() returns an uninitialized struct where the latest history ledger sequence is set to 0. Consequently, the reap system always concludes that there are no ledgers preceding the cutoff point. To fix this bug we need to call app.UpdateLedgerState() to ensure that ledger.CurrentState() is properly initialized.

Another problem with the reap command is that it does not delete from all history tables (e.g. history_trades). This commit fixes this issue by calling DeleteRangeAll() which is used by the ingestion system to clear history tables prior to running a reingest range command.

Known limitations

[N/A]

[tamirms]

two questions:

I assume the fact that horizon db reap neglected to delete rows from the history_trades table was a mistake. Am I right or is that the actual intended behavior?

Should this PR be merged into master or should it remain in the 1.1.0 release?

[abuiles]

@tamirms good catch! 👍

[bartekn]

I assume the fact that horizon db reap neglected to delete rows from the history_trades table was a mistake. Am I right or is that the actual intended behavior?

I think it was a bug, so 👍 for fixing it!

Should this PR be merged into master or should it remain in the 1.1.0 release?

I think we should only use the release branch for breaking changes and some new features we know require more testing before we can release.