Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/horizon: Apply deprecation on some operation types, updating them to the correct value #2132

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jan 16, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update type name for operations: pathPaymentStrictReceive, manageSellOffer, and createPassiveSellOffer. Fixes #2132

Why

The used type doesn't match the operation type, we delayed this change up to 0.25.0 and we are doing it now.

Known limitations

[TODO or N/A]

…TypeManageSellOffer, and OperationTypeCreatePassiveSellOffer.
@abuiles
Copy link
Contributor Author

abuiles commented Jan 16, 2020

This is branched off from int64-string -- I have that as the base for now since there are overlapping changes. I'll update it once we merge int64-string into the release branch.

@abuiles abuiles changed the title Update type name for operations: pathPaymentStrictReceive, manageSellOffer, and createPassiveSellOffer. protocol/horizon: Update type name for operations: pathPaymentStrictReceive, manageSellOffer, and createPassiveSellOffer Jan 16, 2020
@abuiles abuiles changed the title protocol/horizon: Update type name for operations: pathPaymentStrictReceive, manageSellOffer, and createPassiveSellOffer protocol/horizon: Apply deprecation on some operation types, updating them to the correct value Jan 16, 2020
@abuiles abuiles changed the title protocol/horizon: Apply deprecation on some operation types, updating them to the correct value protocols/horizon: Apply deprecation on some operation types, updating them to the correct value Jan 16, 2020
@abuiles abuiles merged this pull request into int64-string Jan 17, 2020
@abuiles abuiles deleted the update-type-names branch January 17, 2020 12:28
@abuiles abuiles restored the update-type-names branch January 17, 2020 12:34
@abuiles
Copy link
Contributor Author

abuiles commented Jan 17, 2020

sorry, I merge this into the int64 branch, undoing it and waiting until we merge that one in the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants