Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/expingest/main.go: Trim experimental ingestion historical data when starting ingestion #2055

Merged
merged 2 commits into from
Dec 13, 2019

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Dec 13, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Trim experimental ingestion historical data when starting ingestion from a history archive snapshot.

Close #2052

Why

Horizon always reingests state using the latest checkpoint ledger and in most cases the sequence of this ledger will be smaller than the latest ingested ledger. Because of this Horizon will attempt to insert old ledgers into exp_history_ledger again. Inserting old ledgers into exp_history_ledger triggers unique constraint errors.

To fix this issue we remove rows from historical ingestion tables that ingestion will insert during the ledger pipeline phase.

Known limitations

[N/A]

…rom a HAS

Horizon always reingests state using the latest checkpoint ledger and in most cases the sequence of this ledger will be smaller than the latest ingested ledger. Because of this Horizon will attempt to insert old ledgers into exp_history_ledger again. Inserting old ledgers into exp_history_ledger triggers unique constraint errors.

To fix this issue we remove rows from historical ingestion tables that we will insert during the ingestion pipeline.
@tamirms tamirms merged commit 5e4d247 into stellar:release-horizon-v0.24.1 Dec 13, 2019
@tamirms tamirms deleted the trim-ledgers branch December 13, 2019 14:28
tamirms added a commit that referenced this pull request Dec 13, 2019
…orical data when starting ingestion (#2055)

Horizon always reingests state using the latest checkpoint ledger and in most cases the sequence of this ledger will be smaller than the latest ingested ledger. Because of this Horizon will attempt to insert old ledgers into exp_history_ledger again. Inserting old ledgers into exp_history_ledger triggers unique constraint errors.

To fix this issue we remove rows from historical ingestion tables that ingestion will insert during the ledger pipeline phase.
abuiles pushed a commit that referenced this pull request Dec 16, 2019
…orical data when starting ingestion (#2055)

Horizon always reingests state using the latest checkpoint ledger and in most cases the sequence of this ledger will be smaller than the latest ingested ledger. Because of this Horizon will attempt to insert old ledgers into exp_history_ledger again. Inserting old ledgers into exp_history_ledger triggers unique constraint errors.

To fix this issue we remove rows from historical ingestion tables that ingestion will insert during the ledger pipeline phase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants