services/horizon: Rename OperationFeeStats to FeeStats

[shivamdixit]

What

Renames OperationFeeStats to FeeStats across the horizon service.

Why

Fixes #1952

Known limitations

N/A

[cla-bot]

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement before a change can be accepted and it doesn't look like we have @shivamdixit on file as having signed it. Please follow the link to sign and let us know when you've signed.

Project Maintainers: After @shivamdixit have let us know they've signed the CLA, check the Google Form Sheet, update the clabot-config with their GitHub Username, then update the PR by commenting with @cla-bot check. If this PR has been opened by a member of the @stellar org, they need adding to the clabot-config list too.

[shivamdixit]

@cla-bot check

[shivamdixit]

@cla-bot check

[leighmcculloch]

@shivamdixit It's a manual process to update @cla-bot after you've filled out the Google Form. The check will result in the same message until that's done.

I've just taken a look and noted you didn't complete the Mailing Address form. Are you unable to provide that required field on the CLA? @ire-and-curses Do we need this field completed?

[leighmcculloch]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[abuiles]

@shivamdixit thanks!

BTW, I updated the branch to release-horizon-v0.24.0, we don't follow trunk based development but something similar to gitflow, where we have a release branch where we add all the new changes for the upcoming version and then merge back to master.

So for your next contribution :) you can branch off from release-horizon-vX.X.X and avoid possible conflicts.

[abuiles]

@shivamdixit sorry, can you actually update the commits so the documentation one is not included (2c65553)?

I think you could do something like

git reset --hard release-horizon-v0.24.0
git cherry-pick 3f64d3c21573b1878fdf7a8d8eaf8519347dcc1a
git push -f

[ire-and-curses]

@shivamdixit It's a manual process to update @cla-bot after you've filled out the Google Form. The check will result in the same message until that's done.

I've just taken a look and noted you didn't complete the Mailing Address form. Are you unable to provide that required field on the CLA? @ire-and-curses Do we need this field completed?

No need. We should just remove that field IMO.

[abuiles]

@shivamdixit I did the fix in your branch, merging this, thanks!

[shivamdixit]

I've just taken a look and noted you didn't complete the Mailing Address form. Are you unable to provide that required field on the CLA? @ire-and-curses Do we need this field completed?

@leighmcculloch To be honest, I don't see a reason to provide Mailing Address for signing CLA form. For the privacy reasons I prefer not to provide that.

So for your next contribution :) you can branch off from release-horizon-vX.X.X and avoid possible conflicts.

@abuiles Thanks! noted.

@shivamdixit I did the fix in your branch, merging this, thanks!

Sorry for late response and thanks for fixing it. Next time I will be more active after sending out a fix.

[abuiles]

@shivamdixit thanks!