exp/orderbook: Fix bug in strict send path finding search #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in `consumeOffersForBuyingAsset()` which manifests when `currentAssetAmount` is not high enough to purchase the selling asset. In such cases `consumeOffersForBuyingAsset()` should return -1, nil but because of the bug the function would return a positive amount with no error
bartekn
reviewed
Oct 21, 2019
| return totalConsumed, nil | ||
| } | ||
| if currentAssetAmount < 0 { | ||
| return -1, errSoldTooMuch |
There was a problem hiding this comment.
Here and in other places where we return errSoldTooMuch: doesn't it result in 500 Internal Server Error returned? Shouldn't we skip the path and continue with the next one instead?
There was a problem hiding this comment.
errSoldTooMuch should never happen. If it does then there is a bug in price.ConvertToBuyingUnits or some other part of the code
There was a problem hiding this comment.
OK, then isn't there a bug somewhere else if this happened in #1856?
There was a problem hiding this comment.
correct, the the bug isn't in this function. I just added this check as a precaution.
The bug is in consumeOffersForBuyingAsset() when amountSold is 0 and err is nil in:
amountSold, err := price.MulFractionRoundDown(int64(currentAssetAmount), d, n)
bartekn
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Summary
There is a bug in
consumeOffersForBuyingAsset()which manifests whencurrentAssetAmountis not high enough to purchase the selling asset. In such casesconsumeOffersForBuyingAsset()should return -1, nil but because of the bug the function returns a positive amount with no error.Fixes #1856