Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Use percentile_disc in fee stats query #1857

Merged

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Oct 17, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

When looking at the Dashboard I realized that when there are a lot of transactions with normal fees and one tx with a much bigger fee the p99 can be interpolated to a huge number. See:

Screenshot 2019-10-17 at 19 24 34

I checked the last few ledgers at the moment of the screenshot and no transaction had such a big fee.

This commit fixes fee stats query to use Postgres' percentile_disc instead of percentile_cont.

@cla-bot cla-bot bot added the cla: yes label Oct 17, 2019
@bartekn bartekn added this to the Horizon 0.23.0 milestone Oct 17, 2019
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to use the discreet value at each percentile rather than interpolating. One question below.

Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bartekn bartekn merged commit f3b2896 into stellar:release-horizon-v0.23.0 Oct 17, 2019
@bartekn bartekn deleted the change-fee-stats-disc branch October 17, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants