services/horizon/internal/actions: Add latest ingested ledger in experimental ingestion endpoints #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
force-pushed
the
latest-ledger-header
branch
from
93e6948
to
a8c2b76
Compare
bartekn
reviewed
Oct 11, 2019
abuiles
reviewed
Oct 11, 2019
tamirms
force-pushed
the
latest-ledger-header
branch
6 times, most recently
from
fc1bed8
to
e9c73cf
Compare
Include a Latest-Ledger header with the sequence number of the last processed ledger by the experimental ingestion system. Also, ensure the endpoint responses contains only data consistent with the sequence number included in the header
tamirms
force-pushed
the
latest-ledger-header
branch
from
e9c73cf
to
1ca39bc
Compare
bartekn
approved these changes
Oct 14, 2019
| @@ -60,6 +60,10 @@ func (tx *orderBookBatchedUpdates) apply() error { | |||
| } | |||
| tx.committed = true | |||
|
|
|||
| if ledger < tx.orderbook.lastLedger { | |||
| return errOutdatedLedger | |||
| } | |||
There was a problem hiding this comment.
We should probably check: tx.orderbook.lastLedger != 0 && ledger != tx.orderbook.lastLedger + 1 to make sure no ledger is skipped.
| GetResource(r *http.Request) (actions.StreamableObjectResponse, error) | ||
| GetResource( | ||
| r *http.Request, | ||
| w actions.HeaderWriter, |
There was a problem hiding this comment.
What do you think about flipping the order so it matches ServeHTTP?
| @@ -28,7 +28,7 @@ type Path struct { | |||
| // Finder finds paths. | |||
| type Finder interface { | |||
| // Returns path for a Query of a maximum length `maxLength` | |||
| Find(q Query, maxLength uint) ([]Path, error) | |||
| Find(q Query, maxLength uint) ([]Path, uint32, error) | |||
There was a problem hiding this comment.
Please update the comment to explain what returned uint32 is.
This was referenced Oct 15, 2019
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a Latest-Ledger header with the sequence number of the last processed ledger by the
experimental ingestion system. Also, ensure the endpoint responses contains only data consistent
with the sequence number included in the header
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Summary
Add
Latest-Ledgerheader with the sequence number of the last processed ledger by the experimental ingestion system. The endpoints built using the experimental ingestion system will always respond with data which is consistent with the ledger inLatest-Ledger.Fixes #1791
Goal and scope
See #1791 for motivation