Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require strkey length is divisible by 8 #1815

Closed
wants to merge 5 commits into from
Closed

require strkey length is divisible by 8 #1815

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2019

closes #1804

@cla-bot
Copy link

cla-bot bot commented Oct 9, 2019

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement before a change can be accepted and it doesn't look like we have @ysz on file as having signed it. Please follow the link to sign and let us know when you've signed.

Project Maintainers: After @ysz have let us know they've signed the CLA, check the Google Form Sheet, update the clabot-config with their GitHub Username, then update the PR by commenting with @cla-bot check. If this PR has been opened by a member of the @stellar org, they need adding to the clabot-config list too.

@ghost
Copy link
Author

ghost commented Oct 9, 2019

CLA signed.

@leighmcculloch leighmcculloch self-requested a review October 11, 2019 16:08
@ire-and-curses
Copy link
Member

@cla-bot check

1 similar comment
@abuiles
Copy link
Contributor

abuiles commented Oct 11, 2019

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Oct 11, 2019

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla: yes label Oct 11, 2019
@stellar stellar deleted a comment from cla-bot bot Oct 11, 2019
@stellar stellar deleted a comment from cla-bot bot Oct 11, 2019
@stellar stellar deleted a comment from cla-bot bot Oct 11, 2019
@leighmcculloch leighmcculloch self-assigned this Nov 20, 2019
@2opremio
Copy link
Contributor

2opremio commented May 5, 2020

This is no longer necessary after #2491 .

@2opremio 2opremio closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch Awaiting requested review from leighmcculloch

Assignees

@leighmcculloch leighmcculloch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strkey: check key is not padded
4 participants
@ire-and-curses @abuiles @2opremio @leighmcculloch