Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: update gopkg.in/yaml.v2 7ad95dd0798a => v2.2.2 #1685

Merged
merged 1 commit into from
Aug 30, 2019
Merged

all: update gopkg.in/yaml.v2 7ad95dd0798a => v2.2.2 #1685

merged 1 commit into from
Aug 30, 2019

Conversation

leighmcculloch
Copy link
Member

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Update gopkg.in/yaml.v2 for transition to Modules (#1634).

From: gopkg.in/yaml.v2@7ad95dd0798a
To: gopkg.in/[email protected]

Diff: go-yaml/yaml@7ad95dd...v2.2.2 (96 commits)

Goal and scope

To make the transition to Modules possible. Some dependencies at their current version have incompatible relationships with other dependencies we have. Dep was more tolerant to incompatible versions than Modules. Making this change ahead of the PR that switches us to Modules makes that PR a functional no-op.

The reason Modules is updating yaml.v2 is because the monorepo is also dependent on github.com/onsi/gomega which had to be upgraded due to another dependency requirement. The version of gomega we're using is explicitly dependent on at least v2.2.1 of yaml.v2 requiring us to update to a newer version.

I'm taking the dependency all the way to v2.2.2 which is the latest patch release. While I don't understand all the changes deeply in the diff, the changes don't appear to be significant.

As a bonus these newer versions of yaml.v2 are released under a more desirable license, Apache License 2.0. The commit we were dependent on previously was released under LGPL 3.

Summary of changes

  • Change the version of the package to the version that Modules selects.

Known limitations & issues

N/A

What shouldn't be reviewed

N/A

@leighmcculloch leighmcculloch requested a review from bartekn August 30, 2019 16:59
Copy link
Member

@accordeiro accordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I wasn't able to find anything in that diff that looked like a breaking change either, nor to find any mention of API changes in their GH releases. Approving :)

@leighmcculloch leighmcculloch merged commit babcfd9 into stellar:master Aug 30, 2019
@leighmcculloch leighmcculloch deleted the issue_1634_update_gopkg.in/yaml.v2 branch August 30, 2019 21:16
@leighmcculloch leighmcculloch removed the request for review from bartekn August 30, 2019 21:16
@leighmcculloch leighmcculloch self-assigned this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants