all: update gopkg.in/yaml.v2 7ad95dd0798a => v2.2.2 #1685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
This PR adds tests for the most critical parts of the new functionality or fixes.I've updated any docs (developer docs,.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
I've updated the relevant CHANGELOG (here for Horizon) ifneeded with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Summary
Update
gopkg.in/yaml.v2
for transition to Modules (#1634).From:
gopkg.in/yaml.v2@7ad95dd0798a
To:
gopkg.in/[email protected]
Diff: go-yaml/yaml@7ad95dd...v2.2.2 (96 commits)
Goal and scope
To make the transition to Modules possible. Some dependencies at their current version have incompatible relationships with other dependencies we have. Dep was more tolerant to incompatible versions than Modules. Making this change ahead of the PR that switches us to Modules makes that PR a functional no-op.
The reason Modules is updating
yaml.v2
is because the monorepo is also dependent ongithub.com/onsi/gomega
which had to be upgraded due to another dependency requirement. The version ofgomega
we're using is explicitly dependent on at leastv2.2.1
ofyaml.v2
requiring us to update to a newer version.I'm taking the dependency all the way to
v2.2.2
which is the latest patch release. While I don't understand all the changes deeply in the diff, the changes don't appear to be significant.As a bonus these newer versions of
yaml.v2
are released under a more desirable license, Apache License 2.0. The commit we were dependent on previously was released under LGPL 3.Summary of changes
Known limitations & issues
N/A
What shouldn't be reviewed
N/A