Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: update ginkgo and gomega for modules transition #1670

Merged
merged 4 commits into from
Aug 29, 2019
Merged

all: update ginkgo and gomega for modules transition #1670

merged 4 commits into from
Aug 29, 2019

Conversation

leighmcculloch
Copy link
Member

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Update ginkgo and gomega to newer versions.

Goal and scope

The transition to Modules (#1634) requires some modules to be updated because Modules requires the same minor versions to be used across test dependencies of our dependencies. There are some dependencies we have imported that require these newer versions of these two modules. This is a low risk change since these modules are not used in production, only in tests.

@leighmcculloch leighmcculloch requested a review from debnil August 29, 2019 05:59
@leighmcculloch leighmcculloch deleted the issue_1634_update_gomega/ginkgo branch August 29, 2019 06:05
@leighmcculloch leighmcculloch removed the request for review from debnil August 29, 2019 06:05
@leighmcculloch leighmcculloch restored the issue_1634_update_gomega/ginkgo branch August 29, 2019 06:12
@leighmcculloch leighmcculloch requested review from accordeiro and removed request for debnil August 29, 2019 14:35
@leighmcculloch leighmcculloch merged commit a27ef0f into stellar:master Aug 29, 2019
@leighmcculloch leighmcculloch deleted the issue_1634_update_gomega/ginkgo branch August 29, 2019 16:31
@leighmcculloch leighmcculloch self-assigned this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants