-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: drop support for go 1.10 #1608
Merged
tomquisel
merged 10 commits into
stellar:master
from
leighmcculloch:issue_1548_drop_support_for_go_1_10
Aug 20, 2019
Merged
all: drop support for go 1.10 #1608
tomquisel
merged 10 commits into
stellar:master
from
leighmcculloch:issue_1548_drop_support_for_go_1_10
Aug 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop support for Go 1.10, which makes the official supported versions: - Go 1.11 - Go 1.12 The officially supported versions of Go are only the last two releases. At this time the last release is Go 1.12, and so only that version and the version prior are supported. Supported versions of Go get bug fixes and security updates, but versions prior do not. The code in this repository is used in critical systems and we should encourage its use only in versions of Go that are receiving security updates. Additionally we plan to move to using Go Modules instead of Go Dep for dependency management. Go Modules are only supported in Go 1.11 onwards.
Note: |
tamirms
approved these changes
Aug 19, 2019
@bartekn @brahman81 You two were mentioned as folks I should check in with before I finalize this change. Could you take a look, I think mostly a sanity check? |
bartekn
approved these changes
Aug 20, 2019
This seems good to me, internally we are already building using |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
Thoroughness
This PR adds tests for the most critical parts of the new functionality or fixes.I've updated any docs (developer docs,.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Summary
Drop support for Go 1.10, which makes the official supported versions:
Goal and scope
The code in this repository is used in critical systems and we should encourage its use with versions of Go that receive security updates.
The officially supported versions of Go are only the last two releases. Right now the last release is Go 1.12, and so only that version and the version prior are supported. Versions prior to 1.11 do not get security updates.
We also plan to move to using Go Modules instead of Go Dep for dependency management. Go Modules are only supported in Go 1.11 onwards.
Summary of changes
Known limitations & issues
N/A
Related
Closes #1548
Related to #1542
Required for #1634