Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizonclient: add support for join param. #1560

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

poliha
Copy link
Contributor

@poliha poliha commented Aug 6, 2019

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Allow users to get transaction information when querying an operation endpoint.
Closes #1521

Goal and scope

Add the join parameter to operations and payments request. This allows horizon server to return transaction information along with an operation response

Summary of changes

  • Added join param type
  • Updated OperationRequest struct
  • Added tests to check that the URL is built correctly.

Known limitations & issues

What shouldn't be reviewed

@poliha poliha added the horizonclient tag for new horizon client located in clients/horizonclient label Aug 6, 2019
@poliha poliha added this to the horizonclient 1.4.0 milestone Aug 6, 2019
@poliha poliha merged commit df86d1f into release-horizonclient-v1.4.0 Aug 6, 2019
@poliha poliha deleted the operation-join-param branch August 6, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
horizonclient tag for new horizon client located in clients/horizonclient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants