Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients/horizonclient: support goroutines #1276

Merged
merged 1 commit into from
May 14, 2019
Merged

Conversation

debnil
Copy link
Contributor

@debnil debnil commented May 14, 2019

This PR makes the new Horizon client goroutine compatible. It (un)locks around access to the ServerTimeMap; concurrent access to this shared resource resulted in an error documented in #1254 . Accordingly, this PR closes that issue.

@debnil debnil changed the title clients/horizonclient: fix concurrency clients/horizonclient: make goroutine compatible May 14, 2019
@debnil debnil changed the title clients/horizonclient: make goroutine compatible clients/horizonclient: support goroutines May 14, 2019
Copy link
Member

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ire-and-curses ire-and-curses added the horizonclient tag for new horizon client located in clients/horizonclient label May 14, 2019
@debnil debnil merged commit 009e6e4 into stellar:master May 14, 2019
@debnil debnil deleted the hclient-lock branch May 14, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
horizonclient tag for new horizon client located in clients/horizonclient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants