txnbuild: add max limit to change trust #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ire-and-curses
requested changes
May 13, 2019
txnbuild/change_trust.go
Outdated
| type ChangeTrust struct { | ||
| Line Asset | ||
| Limit string | ||
| SourceAccount Account | ||
| } | ||
|
|
||
| // MaxTrustlineLimit represents the maximum value that can be passed as trutline Limit |
There was a problem hiding this comment.
can be passed as trutline Limit -> can be set as a trustline limit.
txnbuild/change_trust.go
Outdated
| "github.com/stellar/go/amount" | ||
| "github.com/stellar/go/support/errors" | ||
| "github.com/stellar/go/xdr" | ||
| ) | ||
|
|
||
| // ChangeTrust represents the Stellar change trust operation. See | ||
| // https://www.stellar.org/developers/guides/concepts/list-of-operations.html | ||
| // https://www.stellar.org/developers/guides/concepts/list-of-operations.html. | ||
| // If Limit is omitted, it defaults to txnbuild.MaxTrustlineLimit; the max int64 value. |
There was a problem hiding this comment.
// If Limit is omitted, it defaults to txnbuild.MaxTrustlineLimit; the max int64 value. -> // If Limit is omitted, it defaults to txnbuild.MaxTrustlineLimit.
| type ChangeTrust struct { | ||
| Line Asset | ||
| Limit string | ||
| SourceAccount Account | ||
| } | ||
|
|
||
| // MaxTrustlineLimit represents the maximum value that can be passed as trutline Limit | ||
| var MaxTrustlineLimit = amount.StringFromInt64(math.MaxInt64) |
There was a problem hiding this comment.
Nope you will get an error because the value is returned from a method
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestChangeTrustMaxLimit(t *testing.T) { |
There was a problem hiding this comment.
Did you confirm by looking e.g. in Stellar lab that the limit was set as expected in the XDR? If so this is fine - just include the link to the lab.
ire-and-curses
approved these changes
May 13, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the maximum trustline limit to a change trust operation when no limit is set.
Closes #1265