horizonclient v1.1.0 & txnbuild v1.1.0 #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ire-and-curses
added
txnbuild
bartekn
force-pushed
the
release-horizonclient-v1.1.0
branch
from
6543779 to
0f63acf
Compare
* update client.Fund * update change log * fix space
* Remove old stream method * more comments * fix format * split comment
* set default HTTP client * changes from review
* horizonclient/txnbuild README fixes (#1210) * fix client links in top-level readme * update clients README * mark old client deprecated in godoc short summary * fix code of conduct, standardise example * fix code of conduct/contributing links * txnbuild: enables multiple signatures (#1198) This PR enables multiple signatures on a transaction in the new Go SDK. It also lets every `Operation` type have a different source account than its `Transaction`. These changes are intertwined. Without multiple signatures, every operation in a transaction must share the transaction's source account. Differing source accounts are the most common use case for multiple signatures, and they also test it with greatest completeness. * root repo changelog links to sub-projects (#1214) * keystore: add update-keys endpoints to spec (#1215) We need an endpoint to update the encrypted seed when users forget their passwords. * move keystore to exp to fix build (#1223) * Add minimal files to fix build (#1225) * changelog for txnbuild 1.1
* add package version * fix go fmt
* update effects in protocols/horizon * update client interface * update tests * update changelogs * fix typo
bartekn
force-pushed
the
release-horizonclient-v1.1.0
branch
from
0f63acf to
8b597e5
Compare
bartekn
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge features added to these two libraries back to master.
Unfortunately the diff is misleading, because I accidentally merged a few extra master commits into the branch while trying to pick up the multisig change, which had been merged to master by accident.
I'm not sure why it is showing changes which are already on both master and the branch. For example the top level CHANGELOG is identical between both, but shows up as a change.