Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp/ticker: optimize global market aggregation query #1168

Merged
merged 1 commit into from
Apr 24, 2019
Merged

exp/ticker: optimize global market aggregation query #1168

merged 1 commit into from
Apr 24, 2019

Conversation

accordeiro
Copy link
Member

This PR aims to:

  • Optimize the market aggregation query used to generate the Ticker's market.json file.
  • Fix the wrong signal on the price_change_xx attributes, which was computed using oldest_price - newest_price instead of newest_price - oldest_price.

@accordeiro accordeiro requested a review from tomquisel April 23, 2019 22:30
@accordeiro accordeiro self-assigned this Apr 23, 2019
tomquisel
tomquisel approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@tomquisel tomquisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🎉

@accordeiro accordeiro merged commit 43c62a5 into stellar:master Apr 24, 2019
@accordeiro accordeiro deleted the exp/ticker/mkt-query-optimization branch April 24, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomquisel tomquisel tomquisel approved these changes

Assignees

@accordeiro accordeiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@accordeiro @tomquisel