Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby and Rakefile scripts to be ruby 3.2 compatible #3503

Closed
leighmcculloch opened this issue Mar 26, 2021 · 0 comments · Fixed by #3504
Closed

Update ruby and Rakefile scripts to be ruby 3.2 compatible #3503

leighmcculloch opened this issue Mar 26, 2021 · 0 comments · Fixed by #3504
Assignees
@leighmcculloch

Comments

@leighmcculloch
Copy link
Member

The ruby/Rakefile scripts and their bundler requirements require bundler 1.17.2. When running bundler 1.17.2 on Ruby 3 I see this warning message:

/home/vscode/.rvm/gems/ruby-3.0.0/gems/bundler-1.17.2/lib/bundler/shared_helpers.rb:118: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.

We should probably upgrade to bundler 2 at some point so that bundling doesn't break in the future.
@leighmcculloch leighmcculloch mentioned this issue Mar 26, 2021
Merged
7 tasks
@leighmcculloch leighmcculloch self-assigned this Mar 26, 2021
leighmcculloch added a commit that referenced this issue Apr 14, 2021
@leighmcculloch
Remove stellar_core_commander and update bundler (#3504)
68c8b41 

Remove stellar_core_commander and update bundler version and xdrgen.

Mostly to fix xdrgen in this repo for new Ruby versions.

Stellar_core_commander has really old dependencies which are no longer supported on the latest version of Ruby. Also, according to internal discussions we don't actually use stellar_core_commander anymore.

Bundler is being updated because v1.17.2 of bundler calls functions that are deprecated and soon to be removed from Ruby. Using bundler in this repo outputs warnings saying this.

Close #3503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leighmcculloch leighmcculloch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

all: remove stellar_core_commander and update bundler version
1 participant
@leighmcculloch