-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests don't cleanup their Postgres databases #3268
Comments
Possibly fixed? |
I will test this out. |
It's still broken, I get this error upon uncomenting the
The test passes when the call is commented. |
sreuland
added a commit
to sreuland/go
that referenced
this issue
Jan 18, 2022
… tests in db_test.go
7 tasks
sreuland
added a commit
to sreuland/go
that referenced
this issue
Jan 18, 2022
sreuland
added a commit
to sreuland/go
that referenced
this issue
Feb 10, 2022
…triggered within Close()
sreuland
added a commit
to sreuland/go
that referenced
this issue
Aug 7, 2022
sreuland
added a commit
to sreuland/go
that referenced
this issue
Aug 7, 2022
…triggered within Close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While writing #3267 I found out that the integration tests are not dropping their dedicated Horizon Postgres database.
I tried fixing it (look at the TODOs in the code from the PR above) but it turns out that Horizon's
App
leaves open sessions behind .... even after closing it (leading todatabase is being accessed by other users
errors).This may indicate that Horizon is leaking DB connections, so we should look into it.
The text was updated successfully, but these errors were encountered: