all: Fix improper use of errors.Wrap (#4926)

* all: Fix improper use of errors.Wrap

`errors.Wrap` method returns nil if the first argument passed is also nil.
If `errors.Wrap` is copied from a condition like `if err != nil` to another
one which  also returns `errors.Wrap` but does not overwrite `err` before
the returned value will always be `nil`.

* Update services/horizon/internal/db2/history/claimable_balances.go

Co-authored-by: George <[email protected]>

---------

Co-authored-by: George <[email protected]>
Co-authored-by: Tsachi Herman <[email protected]>

services/horizon/internal/db2/history/claimable_balances.go

@@ -47,7 +47,7 @@ func (cbq ClaimableBalancesQuery) Cursor() (int64, string, error) {
 		}
 		r = parts[1]
 		if l < 0 {
-			return l, r, errors.Wrap(err, "Invalid cursor - first value should be higher than 0")
+			return l, r, errors.New("invalid cursor - first value should be higher than 0")
 		}
 	}
 

services/horizon/internal/db2/history/orderbook.go

@@ -117,7 +117,7 @@ func (q *Q) GetOrderBookSummary(ctx context.Context, sellingAsset, buyingAsset x
 	// we don't expect there to be any inconsistency between levels and offers because
 	// this function should only be invoked in a repeatable read transaction
 	if len(levels) != len(offers) {
-		return result, errors.Wrap(err, "price levels length does not match summaries length")
+		return result, errors.New("price levels length does not match summaries length")
 	}
 	for i, level := range levels {
 		sum := offers[i]
@@ -151,7 +151,7 @@ func (q *Q) GetOrderBookSummary(ctx context.Context, sellingAsset, buyingAsset x
 		} else if sum.Type == "bid" {
 			result.Bids = append(result.Bids, entry)
 		} else {
-			return result, errors.Wrap(err, "invalid offer type")
+			return result, errors.New("invalid offer type")
 		}
 	}
 

services/horizon/internal/db2/history/verify_lock.go

@@ -32,7 +32,7 @@ func (q *Q) TryStateVerificationLock(ctx context.Context) (bool, error) {
 		return false, errors.Wrap(err, "error acquiring advisory lock for state verification")
 	}
 	if len(acquired) != 1 {
-		return false, errors.Wrap(err, "invalid response from advisory lock")
+		return false, errors.New("invalid response from advisory lock")
 	}
 	return acquired[0], nil
 }