Use a default checkpoint frequency when not set explicitly

historyarchive/archive.go

@@ -44,7 +44,8 @@ type ConnectOptions struct {
 	S3Region          string
 	S3Endpoint        string
 	UnsignedRequests  bool
-	// The checkpoint frequency will be 64 unless you are using an exotic test setup.
+	// CheckpointFrequency is the number of ledgers between checkpoints
+	// if unset, DefaultCheckpointFrequency will be used
 	CheckpointFrequency uint32
 }
 
@@ -284,9 +285,6 @@ func (a *Archive) GetXdrStream(pth string) (*XdrStream, error) {
 }
 
 func Connect(u string, opts ConnectOptions) (*Archive, error) {
-	if opts.CheckpointFrequency == 0 {
-		return nil, errors.New("uninitialized checkpoint frequency")
-	}
 	arch := Archive{
 		networkPassphrase:       opts.NetworkPassphrase,
 		checkpointFiles:         make(map[string](map[uint32]bool)),

historyarchive/range.go

@@ -10,6 +10,8 @@ import (
 	"strings"
 )
 
+const DefaultCheckpointFrequency = uint32(64)
+
 type Range struct {
 	Low  uint32
 	High uint32
@@ -19,7 +21,13 @@ type CheckpointManager struct {
 	checkpointFreq uint32
 }
 
+// NewCheckpointManager creates a CheckpointManager based on a checkpoint frequency
+// (the number of ledgers between ledger checkpoints). If checkpointFrequency is
+// 0 DefaultCheckpointFrequency will be used.
 func NewCheckpointManager(checkpointFrequency uint32) CheckpointManager {
+	if checkpointFrequency == 0 {
+		checkpointFrequency = DefaultCheckpointFrequency
+	}
 	return CheckpointManager{checkpointFrequency}
 }
 

ingest/ledgerbackend/captive_core_backend.go

@@ -109,6 +109,7 @@ type CaptiveCoreConfig struct {
 	// HistoryArchiveURLs are a list of history archive urls
 	HistoryArchiveURLs []string
 	// CheckpointFrequency is the number of ledgers between checkpoints
+	// if unset, DefaultCheckpointFrequency will be used
 	CheckpointFrequency uint32
 	// LedgerHashStore is an optional store used to obtain hashes for ledger sequences from a trusted source
 	LedgerHashStore TrustedLedgerHashStore

ingest/ledgerbackend/history_archive_backend.go

@@ -31,7 +31,7 @@ const (
 
 // NewHistoryArchiveBackendFromURL builds a new HistoryArchiveBackend using
 // history archive URL.
-// The checkpoint frequency will be 64 unless you are using an exotic test setup.
+// If unsure, leave checkpointFrequency at 0, the DefaultCheckpointFrequency will be used
 func NewHistoryArchiveBackendFromURL(archiveURL string, checkpointFrequency uint32) (*HistoryArchiveBackend, error) {
 	archive, err := historyarchive.Connect(
 		archiveURL,

services/horizon/internal/ingest/main.go

@@ -157,9 +157,6 @@ type system struct {
 }
 
 func NewSystem(config Config) (System, error) {
-	if config.CheckpointFrequency == 0 {
-		return nil, errors.New("uninitialized checkpoint frequency")
-	}
 	ctx, cancel := context.WithCancel(context.Background())
 
 	archive, err := historyarchive.Connect(