Omit max_ledger when it's 0

stellar · Apr 29, 2022 · 9d0eb3b · 9d0eb3b
1 parent 05e2e57
commit 9d0eb3b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/protocols/horizon/main.go b/protocols/horizon/main.go
@@ -552,7 +552,7 @@ type TransactionPreconditionsTimebounds struct {
 
 type TransactionPreconditionsLedgerbounds struct {
 	MinLedger uint32 `json:"min_ledger"`
-	MaxLedger uint32 `json:"max_ledger"`
+	MaxLedger uint32 `json:"max_ledger,omitempty"`
 }
 
 // FeeBumpTransaction contains information about a fee bump transaction

diff --git a/services/horizon/internal/db2/history/transaction_ledger_bounds.go b/services/horizon/internal/db2/history/transaction_ledger_bounds.go
@@ -79,6 +79,9 @@ func formatLedgerBounds(ledgerBounds *xdr.LedgerBounds) LedgerBounds {
 
 	return LedgerBounds{
 		MinLedger: null.IntFrom(int64(ledgerBounds.MinLedger)),
-		MaxLedger: null.IntFrom(int64(ledgerBounds.MaxLedger)),
+		// elide max_ledger if it's 0 since that means no upper bound
+		MaxLedger: null.NewInt(
+			int64(ledgerBounds.MaxLedger),
+			ledgerBounds.MaxLedger > 0),
 	}
 }