Skip to content

Commit

Permalink
Merge pull request #22 from stellar/optional-seeds
Browse files Browse the repository at this point in the history
Fixes optional validations for stellar custom validators
  • Loading branch information
nullstyle authored Nov 11, 2016
2 parents 5463c74 + 6784daa commit 91a8df7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ This repo is the home for all of the public go code produced by SDF. In additio

## Dependencies

*NOTE: this repo presently uses a fork of govalidator that incorporates https://github.com/asaskevich/govalidator/pull/165. Vendored dependencies must be restored (using `glide install`) to get proper behaviour. In other words, this repo is not currently "go gettable"*

This repository depends upon a [number of external dependencies](./glide.yaml), and we use [Glide](https://glide.sh/) to manage them. Glide is used to populate the [vendor directory](http://glide.readthedocs.io/en/latest/vendor/), ensuring that builds are reproducible even as upstream dependencies are changed. Please see the [Glide](http://glide.sh/) website for installation instructions.

When creating this project, we had to decide whether or not we committed our external dependencies to the repo. We decided that we would not, by default, do so. This lets us avoid the diff churn associated with updating dependencies while allowing an acceptable path to get reproducible builds. To do so, simply install glide and run `glide install` in your checkout of the code. We realize this is a judgement call; Please feel free to open an issue if you would like to make a case that we change this policy.
Expand Down
7 changes: 4 additions & 3 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import:
- package: github.com/rs/cors
- package: goji.io
- package: github.com/asaskevich/govalidator
repo: https://github.com/stellar/govalidator.git
- package: github.com/BurntSushi/toml
- package: github.com/spf13/cobra
- package: gopkg.in/gavv/httpexpect.v1
Expand Down
2 changes: 0 additions & 2 deletions support/config/broken_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build brokentests

package config

import (
Expand Down

0 comments on commit 91a8df7

Please sign in to comment.