docs: move coding conventions into contributing.md (#1751)

Move Go coding conventions from the README.md into the CONTRIBUTING.md file which discusses other requirements for code contributed.

I'm in the process of adding a developing document that includes finer details about how to do things like add dependencies, update them, remove them, as part of the previous work switching to Modules (#1634). I noticed during that work that this section is in the projects readme but is primarily listing more things that someone contributing should be thinking about, and not so much someone who is browsing or importing the repository. It makes more sense for this to live in the contributing document.

CONTRIBUTING.md

@@ -24,3 +24,8 @@ Check out the [Stellar Contribution Guide](https://github.com/stellar/docs/blob/
 
 * Use `gofmt` or preferably `goimports` to format code
 * Follow [Effective Go](https://golang.org/doc/effective_go.html) and [Go Code Review Comments](https://github.com/golang/go/wiki/CodeReviewComments)
+
+### Go Coding conventions
+
+- Always document exported package elements: vars, consts, funcs, types, etc.
+- Tests are better than no tests.

README.md

@@ -65,8 +65,6 @@ Generally, file contents are sorted by exported/unexported, then declaration typ
 
 Often, we provide test packages that aid in the creation of tests that interact with our other packages.  For example, the `support/db` package has the `support/db/dbtest` package underneath it that contains elements that make it easier to test code that accesses a SQL database.  We've found that this pattern of having a separate test package maximizes flexibility and simplifies package dependencies.
 
+### Contributing
 
-## Coding conventions
-
-- Always document exported package elements: vars, consts, funcs, types, etc.
-- Tests are better than no tests.
+Contributions are welcome! See [CONTRIBUTING.md](CONTRIBUTING.md) for more details.