Skip to content

Commit

Permalink
Fix circleci publish_latest_horizon_docker_image job (#2049)
Browse files Browse the repository at this point in the history
Because CircleCI does not build tags by default, any child jobs that rely on a job that only builds on tags will also require the tag filter. In this case, the hold and publish_latest_horizon_docker_image jobs will need the filter for /^horizon-v.*/ tags as well, otherwise, they will not be picked up for running.
  • Loading branch information
tamirms authored Dec 12, 2019
1 parent 6398a58 commit 76835eb
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,20 @@ workflows:
branches:
ignore: /.*/
- hold: # <<< A job that will require manual approval in the CircleCI web application.
filters:
tags:
only: /^horizon-v.*/
branches:
ignore: /.*/
type: approval # <<< This key-value pair will set your workflow to a status of "On Hold"
requires: # We only run the "hold" job when publish_horizon_docker_image has succeeded
- publish_horizon_docker_image
# Pushing stellar/horizon:latest to docker hub requires manual approval
- publish_latest_horizon_docker_image:
filters:
tags:
only: /^horizon-v.*/
branches:
ignore: /.*/
# Pushing stellar/horizon:latest to docker hub requires manual approval
requires:
- hold

0 comments on commit 76835eb

Please sign in to comment.