Breaking change: move TransactionParams.Timebounds

The field is now in TransactionParams.Preconditions.Timebounds
stellar · Mar 24, 2022 · 468e7de · 468e7de
1 parent df7b4c2
commit 468e7de
Show file tree

Hide file tree

Showing 38 changed files with 409 additions and 481 deletions.
diff --git a/clients/horizonclient/examples_test.go b/clients/horizonclient/examples_test.go
@@ -1100,7 +1100,7 @@ func ExampleClient_SubmitFeeBumpTransaction() {
 			IncrementSequenceNum: false,
 			Operations:           []txnbuild.Operation{&op},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewInfiniteTimeout(), // Use a real timeout in production!
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()), // Use a real timeout in production!
 		},
 	)
 	if err != nil {
@@ -1154,7 +1154,7 @@ func ExampleClient_SubmitFeeBumpTransactionWithOptions() {
 			IncrementSequenceNum: false,
 			Operations:           []txnbuild.Operation{&op},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewInfiniteTimeout(), // Use a real timeout in production!
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()), // Use a real timeout in production!
 		},
 	)
 	if err != nil {
@@ -1211,7 +1211,7 @@ func ExampleClient_SubmitTransaction() {
 			IncrementSequenceNum: false,
 			Operations:           []txnbuild.Operation{&op},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewInfiniteTimeout(), // Use a real timeout in production!
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()), // Use a real timeout in production!
 		},
 	)
 	if err != nil {
@@ -1253,7 +1253,7 @@ func ExampleClient_SubmitTransactionWithOptions() {
 			IncrementSequenceNum: false,
 			Operations:           []txnbuild.Operation{&op},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewInfiniteTimeout(), // Use a real timeout in production!
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()), // Use a real timeout in production!
 		},
 	)
 	if err != nil {
@@ -1295,7 +1295,7 @@ func ExampleClient_SubmitTransactionWithOptions_skip_memo_required_check() {
 			IncrementSequenceNum: false,
 			Operations:           []txnbuild.Operation{&op},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewInfiniteTimeout(), // Use a real timeout in production!
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()), // Use a real timeout in production!
 		},
 	)
 	if err != nil {

diff --git a/clients/horizonclient/main_test.go b/clients/horizonclient/main_test.go
@@ -146,7 +146,7 @@ func TestCheckMemoRequired(t *testing.T) {
 					IncrementSequenceNum: true,
 					Operations:           tc.operations,
 					BaseFee:              txnbuild.MinBaseFee,
-					Timebounds:           txnbuild.NewTimebounds(0, 10),
+					Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 10)),
 				},
 			)
 			tt.NoError(err)
@@ -878,7 +878,7 @@ func TestSubmitTransactionRequest(t *testing.T) {
 			IncrementSequenceNum: true,
 			Operations:           []txnbuild.Operation{&payment},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewTimebounds(0, 10),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 10)),
 		},
 	)
 	assert.NoError(t, err)
@@ -946,7 +946,7 @@ func TestSubmitTransactionRequestMuxedAccounts(t *testing.T) {
 			IncrementSequenceNum: true,
 			Operations:           []txnbuild.Operation{&payment},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewTimebounds(0, 10),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 10)),
 		},
 	)
 	assert.NoError(t, err)
@@ -1006,7 +1006,7 @@ func TestSubmitFeeBumpTransaction(t *testing.T) {
 			IncrementSequenceNum: true,
 			Operations:           []txnbuild.Operation{&payment},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewTimebounds(0, 10),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 10)),
 		},
 	)
 	assert.NoError(t, err)
@@ -1075,7 +1075,7 @@ func TestSubmitTransactionWithOptionsRequest(t *testing.T) {
 			IncrementSequenceNum: true,
 			Operations:           []txnbuild.Operation{&payment},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewTimebounds(0, 10),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 10)),
 		},
 	)
 	assert.NoError(t, err)
@@ -1168,7 +1168,7 @@ func TestSubmitTransactionWithOptionsRequest(t *testing.T) {
 			Operations:           []txnbuild.Operation{&payment},
 			BaseFee:              txnbuild.MinBaseFee,
 			Memo:                 txnbuild.MemoText("HelloWorld"),
-			Timebounds:           txnbuild.NewTimebounds(0, 10),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 10)),
 		},
 	)
 	assert.NoError(t, err)
@@ -1202,7 +1202,7 @@ func TestSubmitFeeBumpTransactionWithOptions(t *testing.T) {
 			IncrementSequenceNum: true,
 			Operations:           []txnbuild.Operation{&payment},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewTimebounds(0, 10),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 10)),
 		},
 	)
 	assert.NoError(t, err)
@@ -1293,7 +1293,7 @@ func TestSubmitFeeBumpTransactionWithOptions(t *testing.T) {
 			Operations:           []txnbuild.Operation{&payment},
 			BaseFee:              txnbuild.MinBaseFee,
 			Memo:                 txnbuild.MemoText("HelloWorld"),
-			Timebounds:           txnbuild.NewTimebounds(0, 10),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 10)),
 		},
 	)
 	assert.NoError(t, err)

diff --git a/exp/services/recoverysigner/internal/serve/account_sign_signing_address_test.go b/exp/services/recoverysigner/internal/serve/account_sign_signing_address_test.go
@@ -349,8 +349,8 @@ func TestAccountSign_signingAddressAccountAuthenticatedButSigningAddressInvalid(
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -411,8 +411,8 @@ func TestAccountSign_signingAddressAccountAuthenticatedOtherSignerSelected(t *te
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -477,8 +477,8 @@ func TestAccountSign_signingAddressAccountAuthenticatedTxSourceAccountValid(t *t
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -544,8 +544,8 @@ func TestAccountSign_signingAddressAccountAuthenticatedTxAndOpSourceAccountValid
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -610,8 +610,8 @@ func TestAccountSign_signingAddressAccountAuthenticatedTxSourceAccountInvalid(t
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -673,8 +673,8 @@ func TestAccountSign_signingAddressAccountAuthenticatedOpSourceAccountInvalid(t
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -737,8 +737,8 @@ func TestAccountSign_signingAddressAccountAuthenticatedTxAndOpSourceAccountInval
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -806,8 +806,8 @@ func TestAccountSign_signingAddressPhoneNumberOwnerAuthenticated(t *testing.T) {
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -878,8 +878,8 @@ func TestAccountSign_signingAddressPhoneNumberOtherAuthenticated(t *testing.T) {
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -950,8 +950,8 @@ func TestAccountSign_signingAddressEmailOwnerAuthenticated(t *testing.T) {
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -1031,8 +1031,8 @@ func TestAccountSign_signingAddressEmailOwnerAuthenticatedOpSourceAccountIsAllow
 				},
 				&txnbuild.EndSponsoringFutureReserves{},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -1108,8 +1108,8 @@ func TestAccountSign_signingAddressEmailOwnerAuthenticatedOpSourceAccountInvalid
 				},
 				&txnbuild.EndSponsoringFutureReserves{},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -1175,8 +1175,8 @@ func TestAccountSign_signingAddressEmailOtherAuthenticated(t *testing.T) {
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -1281,8 +1281,8 @@ func TestAccountSign_signingAddressRejectsFeeBumpTx(t *testing.T) {
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)
@@ -1351,8 +1351,8 @@ func TestAccountSign_signingAddressValidContentTypeForm(t *testing.T) {
 					},
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewTimebounds(0, 1),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimebounds(0, 1)),
 		},
 	)
 	require.NoError(t, err)

diff --git a/exp/services/webauth/internal/serve/token_test.go b/exp/services/webauth/internal/serve/token_test.go
@@ -1136,9 +1136,9 @@ func TestToken_jsonInputNoWebAuthDomainSuccess(t *testing.T) {
 					Value:         []byte("ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg"),
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Memo:       nil,
-			Timebounds: txnbuild.NewTimebounds(txMinTimebounds, txMaxTimebounds),
+			BaseFee:       txnbuild.MinBaseFee,
+			Memo:          nil,
+			Preconditions: txnbuild.NewPreconditionsWithTimebounds(txMinTimebounds, txMaxTimebounds),
 		},
 	)
 	require.NoError(t, err)

diff --git a/services/friendbot/init_friendbot.go b/services/friendbot/init_friendbot.go
@@ -120,7 +120,7 @@ func createMinionAccounts(botAccount internal.Account, botKeypair *keypair.Full,
 				IncrementSequenceNum: true,
 				Operations:           ops,
 				BaseFee:              txnbuild.MinBaseFee,
-				Timebounds:           txnbuild.NewTimeout(300),
+				Preconditions:        txnbuild.NewPreconditions(txnbuild.NewTimeout(300)),
 			},
 		)
 		if err != nil {

diff --git a/services/friendbot/internal/minion.go b/services/friendbot/internal/minion.go
@@ -117,7 +117,7 @@ func (minion *Minion) makeTx(destAddress string) (string, error) {
 			IncrementSequenceNum: true,
 			Operations:           []txnbuild.Operation{&createAccountOp},
 			BaseFee:              minion.BaseFee,
-			Timebounds:           txnbuild.NewInfiniteTimeout(),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()),
 		},
 	)
 	if err != nil {

diff --git a/services/horizon/internal/integration/negative_seq_txsub_test.go b/services/horizon/internal/integration/negative_seq_txsub_test.go
@@ -55,7 +55,7 @@ func TestNegativeSequenceTxSubmission(t *testing.T) {
 		SourceAccount:        account,
 		Operations:           []txnbuild.Operation{&op2},
 		BaseFee:              txnbuild.MinBaseFee,
-		Timebounds:           txnbuild.NewInfiniteTimeout(),
+		Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()),
 		IncrementSequenceNum: false,
 	}
 	tx, err := txnbuild.NewTransaction(txParams)

diff --git a/services/horizon/internal/integration/sponsorship_test.go b/services/horizon/internal/integration/sponsorship_test.go
@@ -311,7 +311,7 @@ func TestSponsorships(t *testing.T) {
 			SourceAccount:        newAccount,
 			Operations:           []txnbuild.Operation{preAuthOp},
 			BaseFee:              txnbuild.MinBaseFee,
-			Timebounds:           txnbuild.NewInfiniteTimeout(),
+			Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()),
 			IncrementSequenceNum: true,
 		}
 		preaAuthTx, err := txnbuild.NewTransaction(txParams)

diff --git a/services/horizon/internal/test/integration/integration.go b/services/horizon/internal/test/integration/integration.go
@@ -694,7 +694,7 @@ func (i *Test) CreateSignedTransaction(
 		SourceAccount:        source,
 		Operations:           ops,
 		BaseFee:              txnbuild.MinBaseFee,
-		Timebounds:           txnbuild.NewInfiniteTimeout(),
+		Preconditions:        txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()),
 		IncrementSequenceNum: true,
 	}
 

diff --git a/services/regulated-assets-approval-server/internal/configureissuer/configureissuer.go b/services/regulated-assets-approval-server/internal/configureissuer/configureissuer.go
@@ -119,8 +119,8 @@ func setup(opts Options, hClient horizonclient.ClientInterface) error {
 				SourceAccount: trustorKP.Address(),
 			},
 		},
-		BaseFee:    300,
-		Timebounds: txnbuild.NewTimeout(300),
+		BaseFee:       300,
+		Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimeout(300)),
 	})
 	if err != nil {
 		return errors.Wrap(err, "building transaction")

diff --git a/services/regulated-assets-approval-server/internal/serve/api_tx_approve_test.go b/services/regulated-assets-approval-server/internal/serve/api_tx_approve_test.go
@@ -114,8 +114,8 @@ func TestAPI_txApprove_revised(t *testing.T) {
 					Asset:         assetGOAT,
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewInfiniteTimeout(),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()),
 		},
 	)
 	require.NoError(t, err)
@@ -234,8 +234,8 @@ func TestAPI_txAprove_actionRequired(t *testing.T) {
 					Asset:         assetGOAT,
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewInfiniteTimeout(),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()),
 		},
 	)
 	require.NoError(t, err)
@@ -327,8 +327,8 @@ func TestAPI_txAprove_actionRequiredFlow(t *testing.T) {
 					Asset:         assetGOAT,
 				},
 			},
-			BaseFee:    txnbuild.MinBaseFee,
-			Timebounds: txnbuild.NewInfiniteTimeout(),
+			BaseFee:       txnbuild.MinBaseFee,
+			Preconditions: txnbuild.NewPreconditions(txnbuild.NewInfiniteTimeout()),
 		},
 	)
 	require.NoError(t, err)
@@ -538,8 +538,8 @@ func TestAPI_txApprove_success(t *testing.T) {
 				SourceAccount: issuerKP.Address(),
 			},
 		},
-		BaseFee:    300,
-		Timebounds: txnbuild.NewTimeout(300),
+		BaseFee:       300,
+		Preconditions: txnbuild.NewPreconditions(txnbuild.NewTimeout(300)),
 	})
 	require.NoError(t, err)
 	txe, err := tx.Base64()