require memos of type ID in BuildChallengeTx

stellar · Jan 24, 2023 · 11d5a94 · 11d5a94
1 parent 87f653b
commit 11d5a94
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/txnbuild/transaction.go b/txnbuild/transaction.go
@@ -1027,7 +1027,7 @@ func BuildChallengeTx(serverSignerSecret, clientAccountID, webAuthDomain, homeDo
 			return nil, errors.New("memos are not valid for challenge transactions with a muxed client account")
 		}
 	} else if memo != nil {
-		if _, err := memo.ToXDR(); err != nil {
+		if xdrMemo, err := memo.ToXDR(); err != nil || xdrMemo.Type != xdr.MemoTypeMemoId {
 			return nil, errors.New("memo must be of type MemoID")
 		}
 	}