Manage assets #412
Manage assets #412
Conversation
…ssets # Conflicts: # extension/src/popup/components/accountHistory/TransactionDetail/index.tsx # extension/src/popup/views/Account/index.tsx
…ssets # Conflicts: # extension/src/popup/ducks/transactionSubmission.ts
| balances: Balances; | ||
| networkDetails: NetworkDetails; | ||
| }) => getAssetIconsService({ balances, networkDetails }), | ||
| ); |
There was a problem hiding this comment.
I'm adding assetIcons to the redux store because we always fetch all these icons when we land on Account, and we need them for subsequent views like Manage Assets and Send Payment. I figure we can save ourselves reaching back out for toml files by saving the url's in redux for reuse
Ideally, this will hold an asset's home domain, as well, at some point
|
|
||
| const errorState: TRUSTLINE_ERROR_STATES = error | ||
| ? mapErrorToErrorState(getResultCode(error)) | ||
| : TRUSTLINE_ERROR_STATES.UNKOWN_ERROR; |
There was a problem hiding this comment.
parse the result_code we get back from Horizon and map it to a Error UI
|
The UX is still WIP, so I tried not to go too deep until we finalize some details |
| setErrorAsset: (errorAsset: string) => void; | ||
| } | ||
|
|
||
| const getCodeIssuerStr = (assetCode: string, assetIssuer: string) => |
There was a problem hiding this comment.
❓ can we call this getCanonicalFromAsset or something similar? there's the opposite func in the helpers now, could we move this one next to it in that file? (I'm sure we'll re-use this at some point)
I've been using the term canonical when referring to <asset code>:<issuer>, I've noticed we're not 100% consistent referring to it that way across projects but I think it's a good way to refer to it, and is used in SEPs (though not all idt)
| import "./styles.scss"; | ||
|
|
||
| export enum TRUSTLINE_ERROR_STATES { | ||
| UNKOWN_ERROR = "UNKNOWN_ERROR", |
There was a problem hiding this comment.
| UNKOWN_ERROR = "UNKNOWN_ERROR", | |
| UNKNOWN_ERROR = "UNKNOWN_ERROR", |
| errorMessage: string; | ||
| response: Horizon.TransactionResponse; | ||
| }; | ||
| rejectValue: ErrorMessage; |
| @@ -72,17 +74,10 @@ export const Account = () => { | |||
| }); | |||
There was a problem hiding this comment.
❓ can you use the new sortBalances helper in helpers/account.ts to replace the lines above? (line 68-73)
There was a problem hiding this comment.
Argh, yes, good catch!
|
|
||
| const { balances } = accountBalances; | ||
|
|
||
| if (!balances) { |
There was a problem hiding this comment.
nit: should we also disable the ManageAssets button if no assets? otherwise it will just load this view and then redirect back (or not sure if you were thinking of doing something different for next PR)
There was a problem hiding this comment.
We do actually hide the button based on the isFunded which, now that I'm thinking about it, means the same thing as !balances. I'll create a ticket to address that as isFunded shouldn't be needed
* add Account History detail view * only show From if it exists * label updates * add add/manage assets views * consolidating asset icon logic * undo get asset icons consolidation * finish modify trustline and add error screens * show existing balance during error * handle error cases for XLM * handle possible errors * set tx timeout * pr comments
Screen.Recording.2022-03-28.at.8.21.45.PM.mov