Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users in full screen mode, they run the risk of leaving Freighter open in a tab for long periods of time (previously impossible). This can lead to a couple of issues:
To help mitigate issue 1, I am showing a notification to the user that they might have stale data after a period of time and will need to reload. The real solution is to implement streaming or polling to keep the app up to date, but that is a bigger ticket and I think should come in an iterative follow up.
For 2, when the user is in full screen mode, we should log out accounts that are inactive, similar to any banking app. This inactivity check is only enabled when the user is in fullscreen mode. The inactivity timer resets when a user navigates to a different page. In the demo video below, I set the timer to be 10 seconds to illustrate the UX. Once the user stops navigating, the app waits 10 seconds and then logs them out. In real life, they would be something like 20 minutes.