upgrade soroswap and fix bug #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
commented
Oct 9, 2024
| @@ -213,7 +213,7 @@ export const SendAmount = ({ | |||
| if (values.destinationAsset) { | |||
| dispatch(saveDestinationAsset(values.destinationAsset)); | |||
| isDestAssetScam = isAssetSuspicious( | |||
| accountBalances.balances?.[destinationAsset].blockaidData, | |||
| accountBalances.balances?.[destinationAsset]?.blockaidData, | |||
There was a problem hiding this comment.
this was throwing an error for soroswap assets because the user doesn't actually have these assets in their balances yet
piyalbasu
commented
Oct 9, 2024
| baseFee.plus(new BigNumber(minResourceFee)).toString(), | ||
| ), | ||
| ); | ||
| if (!transactionFee) { |
There was a problem hiding this comment.
we do a similar check in the other pathways - this keeps the effect from running indefinitely
piyalbasu
commented
Oct 9, 2024
| }, | ||
| }, | ||
| { | ||
| protocol: Protocol.PHOENIX, |
There was a problem hiding this comment.
apparently we needed to add another liquidity provider to ensure we could get a usable pathway for swap
aristidesstaffieri
approved these changes
Oct 9, 2024
piyalbasu
added a commit
that referenced
this pull request
Oct 10, 2024
* adds fetchJson to handle non json fetch responses * awaits json response * encodes xdr for query param usage * [FEATURE] malicious tx warning, sign-tx (#1449) * adds response handling and warning for malicious case of tx scan * tweaks malicious tx warning copy * use internal hook loading and data vars * adds warning variant to tx warning * Added translations * restore initial null value for tx scan data * adds scan labels for all scan result types, tweaks styles * Added translations * adds unit tests for grant access views scan site labels * adds sac contract check in transfer detail, formats transfers like regular payments * adds unit test for sac transfer history item * memoizes translation fn as dependency of history item effect * Feature/blockaid asset UI warning (#1452) * use Blockaid asset scanning instead of stellar.expert * add new scam asset icon and icorporate throughout send/swap flow * save webpack updates for a future PR * rm unused dep * fix translations * add better copy for modals * add translations * removes configurable fee constraint on token transfers * take into account min resource fee for toke payments * split out simulation api to internal api, update tests to use correct fees flow * qa fixes for blockaid asset check (#1460) * add Blockaid tests for account, manage assets, send and swap flows (#1454) * adds tx scan during send payment flow tx details * adds failed simulation state to tx scan label, updates tx scan response types, updates non json response error * removes unused cast functions * add Blockaid announcement modal (#1465) * add Blockaid announcement modal * removing console.log * add blockAnnounced data migration * rm unused prop * fix translations * split tx scan for classic sends and swaps * pulls tx construction out into helper * Bugfix/show non malicious blockaid info (#1469) * show all warnings for non-benign tokens * adjust line height * remove fall back result type * fixes transparent bg on asset warning * handle complete blockaid data fro indexer (#1474) * handle complete blockaid data fro indexer * cast blockaid data when retrieving from sortedBalances * add better typing for standalone balances (#1475) * add better typing for standalone balances * finish balances typing and add tests * add blockaid scan for custom mainnet and use blockaid lib for types (#1476) * makes suspicious asset check stricter * use blockaid lib for blockaid scan tx result (#1480) * move terser to only production config (#1481) * check for scam asset warning message in send flow (#1482) * Feature/rm stellar.expert safety checks (#1483) * rm stellar.expert's checks for malicious assets, domains, addresses * rm new asset check * add translations * rm unused icon * don't block submission on suspicious asset * reassing collectedTags when not validating memo * adds advanced settings guide * adds add asset docs * adds docs for account, network settings, make payment, add asset, and sign XDR * fix grammar Co-authored-by: Piyal Basu <[email protected]> * fix typo Co-authored-by: Piyal Basu <[email protected]> * fix grammar Co-authored-by: Piyal Basu <[email protected]> * fix grammar Co-authored-by: Piyal Basu <[email protected]> * fix grammar Co-authored-by: Piyal Basu <[email protected]> * splits guide into 2 groups, updates copy importing new key instructions * split intro in sidebar, expand intro to include new docs * clarify seed phrase import copy * rename "blocked accounts" to "memo required accounts" (#1485) * removes benign scan label for site scans * skip benign label test for now * updates tx scan copy and adds malicious tx scan state for buttons * tweaks grant access width to stop button overflow, tweaks cancel text * better loading states while loading blockaid data (#1486) * better loading states while loading blockaid data * rm console.log * adjust blockaid-related styling (#1493) * adjust blockaid-related styling * reset testing conditional * scan search results in a loop to avoid long loading times (#1494) * scan asset results in manual add (#1496) * add helper to determine if a tx is suspicious (#1497) * show error button in send flow warning (#1499) * restore dropped styles for modal subject * redesign popup blockaid warnings (#1503) * redesign popup blockaid warnings * fix test * add ability to copy truncated words * rollback testid change * adjust padding on buttons (#1504) * adds new test token address after testnet reset * comments blockaid announcement, tweaks e2e details in tests * fixes loading state for token transfer details after transfer, fixes history item display for payments to C addres using lumens * updates test for history item change * fix stale state instead by manually dismissing loading when not scanning tx after sends in details * restore login and fund on first payment test * make e2e tests run in sequence * restore slow timeout settings for payment tests * avoids rescanning classic transactions after tx is sent in details * add explicit prop to scan tx in tx details * make sure to show sim errors in send flow; add tests (#1506) * make sure to show sim errors in send flow; add tests * rollback unnecessary change * Fix flakey tests (#1509) * Added translations * fix flakey tests * adds account creator base tests * adds success flow test for account creator * upgrade soroswap and fix bug (#1514) --------- Co-authored-by: Aristides Staffieri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.