Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] Improving Freighter developer docs #1513

Closed
wants to merge 77 commits into from

Conversation

piyalbasu
Copy link
Contributor

@piyalbasu piyalbasu commented Oct 8, 2024

Adding some useful information about things we've discovered while developing for Soroban and third party services

aristidesstaffieri and others added 30 commits August 27, 2024 12:32
* adds response handling and warning for malicious case of tx scan

* tweaks malicious tx warning copy

* use internal hook loading and data vars

* adds warning variant to tx warning

* Added translations

* restore initial null value for tx scan data
* use Blockaid asset scanning instead of stellar.expert

* add new scam asset icon and icorporate throughout send/swap flow

* save webpack updates for a future PR

* rm unused dep

* fix translations

* add better copy for modals

* add translations
* add Blockaid announcement modal

* removing console.log

* add blockAnnounced data migration

* rm unused prop

* fix translations
* show all warnings for non-benign tokens

* adjust line height

* remove fall back result type
* handle complete blockaid data fro indexer

* cast blockaid data when retrieving from sortedBalances
* add better typing for standalone balances

* finish balances typing and add tests
@piyalbasu piyalbasu changed the base branch from master to release/5.23.2 October 8, 2024 21:50
@piyalbasu piyalbasu changed the title [DON'T MERGE] Docs/soroban docs [DON'T MERGE] Improving Freighter developer docs Oct 8, 2024
Base automatically changed from release/5.23.3 to master October 10, 2024 16:33
…oban-docs

# Conflicts:
#	@shared/api/package.json
#	@shared/api/types.ts
#	docs/sidebars.js
#	extension/src/popup/__testHelpers__/index.tsx
#	extension/src/popup/components/sendPayment/SendAmount/index.tsx
#	extension/src/popup/components/sendPayment/SendSettings/Settings/index.tsx
#	yarn.lock
Copy link

Report too large to display inline

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Deprecated npm/[email protected]
  • Reason: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
⚠︎

View full report↗︎

Next steps

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@piyalbasu piyalbasu mentioned this pull request Oct 22, 2024
@piyalbasu
Copy link
Contributor Author

Closing in favor of #1562

@piyalbasu piyalbasu closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants