Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-341] Fix missing type field of the PutCustomerRequest in SEP-24 post transactions #944

Conversation

lijamie98
Copy link
Collaborator

@lijamie98 lijamie98 commented Jun 15, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

Fix missing type field of the PutCustomerRequest in SEP-24 post transactions.

Please also refer to: stellar/stellar-docs#165 (comment)

Why

Bug fixes.

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr944.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr944.previews.kube001.services.stellar-ops.com/

@lijamie98 lijamie98 requested a review from Ifropc June 15, 2023 18:48
@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr944.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr944.previews.kube001.services.stellar-ops.com/

@lijamie98 lijamie98 force-pushed the feature/anchor-341-add-type-to-put-customer-call branch from bfac69a to 7a2e22f Compare June 16, 2023 16:27
@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr944.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr944.previews.kube001.services.stellar-ops.com/

@lijamie98 lijamie98 force-pushed the feature/anchor-341-add-type-to-put-customer-call branch from 7a2e22f to bd6b14b Compare June 20, 2023 16:34
@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr944.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr944.previews.kube001.services.stellar-ops.com/

@lijamie98 lijamie98 mentioned this pull request Jun 20, 2023
4 tasks
@lijamie98 lijamie98 merged commit 98e7a46 into stellar:develop Jun 20, 2023
@lijamie98 lijamie98 self-assigned this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants