[ANCHOR-610] Fix log level #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipliu
reviewed
Feb 8, 2024
| .forEach( | ||
| (String cfgName, Object cfgValue) -> { | ||
| if (cfgName.startsWith("logging.level") && cfgValue instanceof String) { | ||
| LoggingSystem system = |
There was a problem hiding this comment.
nit: Do we need to call this for every source?
There was a problem hiding this comment.
Actually not, but it's just for one partner in the legacy branch (and most likely they will only use it for debug logs), so I decided to keep it simple
| @@ -53,12 +53,4 @@ Configutation: | |||
| level: info | |||
| AppenderRef: | |||
| - ref: ${env:LOG_APPENDER:-console_appender} | |||
| Logger: | |||
There was a problem hiding this comment.
What are the log levels set to after removing this?
There was a problem hiding this comment.
Default is always INFO
philipliu
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove hardcoded DEBUG level of Stellar and add support of dynamic logging configuration reload
Context
Previously, it was impossible to set DEBUG level to Stellar level config
Testing
Manually tested with different log levels
Documentation
N/A
Known limitations
N/A