Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-508] SEP-6: Custody integration #1179

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

philipliu
Copy link
Contributor

@philipliu philipliu commented Oct 26, 2023

Description

This implements the custody service RPC actions. This includes payments as well as refunds.

Context

SEP-6 will support custodians.

Testing

  • ./gradlew test

Documentation

Known limitations

N/A

@philipliu philipliu force-pushed the feature/anchor-508-custody branch 5 times, most recently from 27a84da to 5263607 Compare October 31, 2023 20:04
@philipliu philipliu force-pushed the feature/anchor-508-custody branch from 5263607 to 31bc3eb Compare October 31, 2023 21:44
@philipliu philipliu marked this pull request as ready for review October 31, 2023 22:22
@philipliu
Copy link
Contributor Author

SEP validation suite is failing pending this change stellar/stellar-anchor-tests#132. Once it's merged, I'll update this PR to bump the package version and also remove setting account_id in the withdraw response.

Copy link
Collaborator

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipliu philipliu merged commit a758fa7 into stellar:sep-6 Nov 2, 2023
5 checks passed
@philipliu philipliu deleted the feature/anchor-508-custody branch November 2, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants