[ANCHOR-362] SEP-6: Update reference server to set required_customer_info_updates #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijamie98
reviewed
Oct 17, 2023
api-schema/src/main/java/org/stellar/anchor/api/callback/PutCustomerRequest.java
Outdated
Show resolved
Hide resolved
lijamie98
approved these changes
Oct 19, 2023
| @@ -99,8 +116,7 @@ class Sep6End2EndTest(val config: TestConfig, val jwt: String) { | |||
| ) | |||
| assertEquals(completedDepositTxn.transaction.id, transactionByStellarId.transaction.id) | |||
|
|
|||
| val expectedStatuses = | |||
| listOf("incomplete", "pending_anchor", "pending_customer_info_update", "completed") | |||
| val expectedStatuses = listOf("incomplete", "pending_customer_info_update", "completed") | |||
There was a problem hiding this comment.
nit: Can we use the enum here?
| @@ -55,11 +55,18 @@ class CustomerService(private val customerRepository: CustomerRepository) { | |||
| customer.copy( | |||
There was a problem hiding this comment.
💡 Is there anything like BeanUtils in Kotlin?
There was a problem hiding this comment.
Or use gson.toJson and gson.fromJson for copying?
I think this is for the reference and does not require critical performance but rather explanations.
There was a problem hiding this comment.
I wrote it this way since I don't want null request fields to delete a previously set customer field. By default, BeanUtils#copyProperties does not ignore null fields, we would need to write a wrapper around it if we want this behavior. This is the same reason, I did not use gson here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the SEP-6 E2E test to use the
required_customer_info_updatesfield when providing KYC updates.Context
Currently, this field is not set by the reference server implementation. This is needed so that the demo wallet could prompt the user to submit the missing KYC information.
Testing
./gradlew testKnown limitations
N/A