[Chore] Merge develop into sep-6
#1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith corresponding request validation and basic error handling (stellar#968) SDFSOF-63 - Added implementation of endpoint for handling RPC calls with corresponding request validation and basic error handling What Implementation of endpoint for handling RPC calls with request validation and error handling Why This endpoint will handle RPC calls that should replace PATCH /transactions REST endpoint
…lar-anchor-sdk into SDFSOF-64
…refund_initiated and notify_refund_sent. (stellar#972) SDFSOF-64 - Added handlers for notify_onchain_funds_received, notify_refund_initiated and notify_refund_sent. What Added handlers for notify_onchain_funds_received, notify_refund_initiated and notify_refund_sent Why Those handlers handle status transfer and update corresponding data in the database
### What - Custody Server: - new service; - ServiceRunner updates; - `Fireblocks` integration; - `Fireblocks` transactions reconciliation job; - run configuration for IntelliJ IDEA. - Anchor Config: - custody and `Fireblocks` configuration; - RPC configuration. - Kotlin Reference Server: - feature toggle to switch between RPC API and `PATCH /transactions` endpoint; - feature toggle to enable/disable custody mode. - RPC API: - RPC endpoint; - method handlers; - trustline check job; - RPC API support for Observer. - End2End tests: - `AnchorPlatformApiRpcEnd2EndTest`; - `AnchorPlatformCustodyApiRpcEnd2EndTest`; - `AnchorPlatformCustodyEnd2EndTest`; - run configurations for IntelliJ IDEA. - Integration tests: - `AnchorPlatformCustodyIntegrationTest`; - `AnchorPlatformIntegrationTest`. - DB migration scripts: - `custody_transaction` table; - `transaction_pending_trust` table. - Unit tests.
…1068) <!-- If you're making a doc PR or something tiny where the below is irrelevant, delete this template and use a short description, but in your description aim to include both what the change is, and why it is being made, with enough context for anyone to understand. --> ### Description Fix the bug where `client_id` was not passed to `getRate()` when the customer of the wallet exists. ### Context Bug fix ### Testing ./gradlew test --------- Co-authored-by: Jiahui Hu <[email protected]>
<!-- If you're making a doc PR or something tiny where the below is irrelevant, delete this template and use a short description, but in your description aim to include both what the change is, and why it is being made, with enough context for anyone to understand. --> ### Description This change adds list of `destination_accounts` into the clients configuration (only for type `custodial`) On SEP-24 deposit, we validate that account either matches SEP-10 (previous impl), or is in `destination_accounts` list for this client (wallet) ### Context Currently, if wallet wants to use a different destination account for deposits (different from SEP-10 authenticated account), it will raise an error. While it makes sense for non-custodial case (otherwise, we allow to transfer money to non-KYCd accounts), it’s a blocker for custodial case. Custodial wallets may have 1 or more hot wallets, separated from their authentication account. ### Testing <!-- How was this change tested? --> <!-- Default to `./gradlew test` but if there are other steps required to test, include them here. --> `./gradlew test` ### Known limitations N/A
### Description This updates the PR template so it removes all Markdown comments and replaces them with explicit TODOs. ### Context This prevents developers from forgetting to delete the Markdown comments when merging their PR. ### Testing N/A ### Known limitations N/A
) ### Description 1. Turn on Gradle concurrency for `core` and `api-schema` 2. Remove `clearAllMocks` and `unmockAll` calls in `@AfterEach` functions to avoid side-effects on concurrent tests. 3. Carefully handle `mockkStatic` objects. 4. `Sep10Challenge` is suspected to be thread-unsafe. Turn on `synchronized` to avoid race condition. ### Context Test acceleration.
<!-- If you're making a doc PR or something tiny where the below is irrelevant, delete this template and use a short description, but in your description aim to include both what the change is, and why it is being made, with enough context for anyone to understand. --> ### Description Add sep38.requires_sep10 configuration with default value to FALSE ### Context Currently, according to the SEP-38 spec, some of the SEP38 endpoints have SEP-10 as optional. This task seeks ensure we support this optionality by add configurability to these endpoints' SEP-10 requirements. ### Testing Tests were added to verify endpoints url pattern was added to filter if auth is required
… customizability (stellar#1142) ### Description - Restructure Sep1 service functions for extensibility and customizability. - Replaced the static mocks with member functions of `Sep1Service`.
JiahuiWho
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merges
developintosep-6. The RPC API and Custody service changes make up the bulk of the commits.Context
Catch up
sep-6branch todevelopTesting
./gradlew testKnown limitations
N/A