Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-439] Remove transaction store from reference server #1105

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

philipliu
Copy link
Contributor

@philipliu philipliu commented Sep 12, 2023

Description

This removes the ActiveTransactionStore from the Kotlin reference server. Previously, this was used to track which transactions were pending KYC info updates. Now, we request the transactions from the platform.

Context

This is part of a series of commits to clean up the reference server implementation.

Testing

./gradlew test

Known limitations

N/A

@philipliu philipliu changed the title [ANCHOR-439] Clean up deposit reference server implementation [ANCHOR-439] Remove transaction store from reference server Sep 13, 2023
@philipliu philipliu marked this pull request as ready for review September 13, 2023 19:23
@lijamie98
Copy link
Collaborator

lijamie98 commented Sep 14, 2023

Can we change the branch name to: feature/anchor-439-clean-up?

@philipliu
Copy link
Contributor Author

@lijamie98 I would need to open a new PR. This branch won't be long-lived and it's in my personal fork, so I don't think the branch naming conventions need to apply here.

@philipliu philipliu merged commit 5b090f4 into stellar:sep-6 Sep 14, 2023
@philipliu philipliu deleted the fix/anchor-439-cleanup branch September 14, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants