Dev -> main 2.2.2 #1099
Merged
Dev -> main 2.2.2 #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description The changes include: 1. Introduces a new plugin to catch and map exceptions to a HTTP error code. 2. Put the `/invalidate_clabe` endpoint behind a configuration. 3. Re-introduces the SEP-12 validation from stellar-anchor-tests. Previously, when a GET /customer request does not include an account/memo, the query does not assert that they are null. This caused a race when updating an account that maps to many customers. ### Context Address the comments from the previous PR #1060. ### Testing `./gradlew test` ### Known limitations N/A
…sionName Gradle task (#1080) ### Description Back merge `2.2.1` to `develop` Fix the mistakenly removed printVersionName Gradle task
…SepServiceTest (#1089) ### Description Add missing `clearAllMocks()` calls in `Sep1ServiceTest`. ### Context The `RequestLoggerFilterTest` fails from time to time. We suspect it is caused by some un-cleared static mocks from previous tests. However, I am not able to re-produce the issue at this moment. I made a fix based on possible un-cleared static mocks that may affect the stability of the tests. If the bug happens again, we should re-open this bug with detailed log messages.
### Description This is to add jacococ test report to PR workflow, to monitor test coverage change ### Testing After PR being published, there should be a github-action bot comment in your PR with test coverage. Please see #1081 (comment) for example. Note that this PR is published from a branch on original repo instead of a forked repo. ### Known limitations 1. For now Github only grant apps write permission (which is needed to make comment) to original repo, and read permission to forked repo, that mean this action will only works on PR created from original repo. I have created a ticket https://stellarorg.atlassian.net/browse/ANCHOR-433 to follow up on this and try to find a work around for forked repo For more info about github permission please refer to https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token 2. Currently the min-coverage-overall is set to 40 and min-coverage-changed-files is 60, this is just for testing, will be changed accordingly. --------- Co-authored-by: Reece Markowsky <[email protected]> Co-authored-by: Philip Liu <[email protected]>
…ng transactions in observer (#1090)
<!-- If you're making a doc PR or something tiny where the below is irrelevant, delete this template and use a short description, but in your description aim to include both what the change is, and why it is being made, with enough context for anyone to understand. --> ### Description Add missing refund memo to the platform trasaction ### Context ### Testing ### Known limitations N/A
… Gradle test (#1094) ### Description Refactored the test to stabilize the test.
JakeUrban
approved these changes
Sep 7, 2023
Code Coverage
Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Testing
./gradlew testKnown limitations