Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SEP suite validation in 1.x actions #1093

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

JakeUrban
Copy link
Contributor

Description

Removes the SEP validation test suite from our CI pipeline.

Context

Maintaining working preview deployments and using them for our SEP validation test suite is too high of a maintenance burden for the usage 1.x has in the ecosystem. We can run the same tests locally before releasing.

@JakeUrban JakeUrban requested a review from lijamie98 September 6, 2023 17:00
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@JakeUrban JakeUrban requested a review from Ifropc September 6, 2023 20:50
Copy link
Contributor

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Getting the CI to pass in the 1.x branch is not trivial. Can we update the PR template to remind the developer to run the SEP validation tests in the Testing section in lieu of GH actions?

@JakeUrban JakeUrban merged commit c6faae4 into legacy/main-1.2 Sep 6, 2023
@JakeUrban JakeUrban deleted the remove-sep-suite-for-1.x branch September 6, 2023 21:17
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants