Delete wallet

[deckar01]

Update delete_wallet.js.
Expose delete on wallet prototype.
Gave up on adding a test and added a stub description.

I will need to bump the version and cut a release so we can pull the new feature into the client.

Fixes #5.

[bartekn]

The only problem I can see is that after running wallet.delete users will still be able to send requests using other methods (that will fail because stellar-wallet will return not_found). One of possible solutions is to throw WalletNotFound in all methods when server returns not_found. The other solution would be to add deleted flag to Wallet object and throw WalletNotFound before even sending request to stellar-wallet server.

[deckar01]

@bartekn I don't see the utility in adding a bunch of code to explicitly keep a deleted state and return errors. The wallet server already rejects the request for us if someone tries to keep using the wallet after deleting it.

[bartekn]

The wallet server already rejects the request for us if someone tries to keep using the wallet after deleting it.

OK, so still we need to add code that throws WalletNotFound/Forbidden in some methods. I wasn't aware of delete functionality when I was developing them.

[deckar01]

Instead of hard coding the errors we expect into every protocol request, we should pass all errors to a middleware error handler. This will allow us to catch errors properly even if we don't expect them ahead of time.

[coveralls]

Coverage decreased (-1.16%) when pulling 366cc9a on delete-wallet into a146d75 on master.

@deckar01: This is likely due to errors.getProtocolError() not having any tests.

[deckar01]

I added errors.getProtocolError() which matches the response code of "fail"ed requests to the proper error objects.

[bartekn]

👍 We can add some tests later. I've created GH issue for this: #9.