This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
sdk/agent: add event handlers #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
leighmcculloch
added a commit
that referenced
this pull request
Aug 26, 2021
Update escrow account on-network balance that is cached in the channel whenever sending or receiving a payment that looks like it exceeds the last known available balance. If a payment is exceeding the balance the only option we have is to stop and close the channel, so we may as check the network to see if the balance is updated which might allow the payment to succeed. I think the usefulness of this balance update is questionable given we will soon have the agent using the state's ingestion to update the balances, but in the interim I need to update the balances one way or another to get tests I'm writing for #225 and #226 to pass. This seems like a good temporary hold over and something we can evaluate in the near future if we still need. I removed the TODO to remove the existing check because it's a little fuzzy to me if we really want to do that. There's no test in this PR for this change because I'm writing tests for the agent in #242 which incorporates a few things that make writing tests for the agent much more straight forward.
|
Superseded by #257 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add event handlers for the things that can occur in the background during open, payment, and close.
Why
The agent receives messages from the other participant containing confirmations/responses to requests made by this recipient, and requests from the other participant. Some of these operations that take place in the background need to be made known to the application using the agent.
The agent will also monitor the state of the network for changes that require action, and once that logic is added we'll need to add events using the same pattern.
Close #226
Known Limitations
This change is somewhat limited because some of the change depends on ingestion having been integrated into the agent, but I'm deferring doing that integration until the integration and state changes have been finished in the state package. Because of that there are some TODOs, but I think it is worth merging this and revisiting it during the ingestion work.