This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft and is likely incomplete.
I've taken a time-boxed pass at upgrading the
stellar/go
dependency fromhorizonclient-v3.0.0
tohorizonclient-v8.0.0
. I mostly just wanted to explore, understand, and validate assumptions about how Kelp could be upgraded, assuming that the upgrade path would not be smooth.The intention was to understand, not necessarily deliver an upgrade.
I've opened this draft PR to have this change run on Kelp's CI, to see if at least from CI's perspective if this idea for how to make the upgrade happen, has substance or creates more problems than it solves.
The approach I've taken is to:
github.com/stellar/go
.github.com/stellar/[email protected]/build
by vendoring that package inside of kelp.github.com/stellar/go/xdr
to their new names, since some XDR types had their names changed.Maybe fix #741