Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Upgrade to use stellar/[email protected] #748

Merged
merged 8 commits into from
Nov 5, 2021
Merged

Upgrade to use stellar/[email protected] #748

merged 8 commits into from
Nov 5, 2021

Conversation

leighmcculloch
Copy link
Contributor

@leighmcculloch leighmcculloch commented Nov 4, 2021

This PR is a draft and is likely incomplete.

I've taken a time-boxed pass at upgrading the stellar/go dependency from horizonclient-v3.0.0 to horizonclient-v8.0.0. I mostly just wanted to explore, understand, and validate assumptions about how Kelp could be upgraded, assuming that the upgrade path would not be smooth.

The intention was to understand, not necessarily deliver an upgrade.

I've opened this draft PR to have this change run on Kelp's CI, to see if at least from CI's perspective if this idea for how to make the upgrade happen, has substance or creates more problems than it solves.

The approach I've taken is to:

  • Upgrade github.com/stellar/go.
  • Preserve use of the old github.com/stellar/[email protected]/build by vendoring that package inside of kelp.
  • Update references to types and functions within github.com/stellar/go/xdr to their new names, since some XDR types had their names changed.
  • Make zero functional changes.

Maybe fix #741

plugins/sdex.go Outdated Show resolved Hide resolved
@nikhilsaraf nikhilsaraf marked this pull request as ready for review November 5, 2021 03:30
Copy link

@ddombrowsky ddombrowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit of a hack to put in a module from the old version of the SDK, but I think it works for now. In the long run it's cleaner than forking the SDK itself.

Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @leighmcculloch !

@nikhilsaraf nikhilsaraf merged commit 2750806 into stellar-deprecated:master Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill Tracker cannot unmarshal string into Go struct field Price._embedded.records.price.n of type int32
3 participants